Prateek Saxena [Thu, 19 Jul 2018 05:02:24 +0000 (10:32 +0530)]
LogPager: Add backwards-compatibility for hide_[type]_log URL params
Also, the $default value in LogEventsList#getFiltersDesc was not
being generated properly and would have always been an empty array.
Bug: T199856
Change-Id: Id286c76259406521f12cda67a4a715032e022637
Bartosz Dziewoński [Wed, 18 Jul 2018 18:09:39 +0000 (20:09 +0200)]
HTMLMultiSelectField: Improve compat with GET forms with no wpFormIdentifier
Now it behaves more like HTMLCheckField: if there is clearly a value
submitted, it will load it.
Setting wpFormIdentifier is still needed for forms with default-on
checkboxes (without form identifier, it is impossible to distinguish a
page view without form submission, and form submission with default-on
checkbox unchecked).
In particular, this fixes the 'Show additional logs' checkboxes on
Special:Log: they no longer get unchecked after form submission.
Change-Id: Ief74a7e424b37ccd44759133b3cb8665275314a6
Bartosz Dziewoński [Wed, 18 Jul 2018 17:45:40 +0000 (19:45 +0200)]
LogEventsList: Remove options not used by HTMLForm
HTMLForm gets the input value from the request. The values
specified in the form descriptor were never used. (You can specify a
default value, but that uses the 'default' key anyway.)
Change-Id: I27934e1118492371e547dd5e94feb172a0510cc9
Prateek Saxena [Wed, 18 Jul 2018 05:08:03 +0000 (10:38 +0530)]
LogEventsList: Use GET in HTMLForm
I missed this during conversion.
Follows-up on Iba3c6aa5ac40dcdee0792c2d045b238b02d76521.
Bug: T199856
Change-Id: If3f228425b217c9ccdb7d32e0bc899647797ed70
Aaron Schulz [Wed, 11 Jul 2018 12:54:51 +0000 (13:54 +0100)]
Switch callers from ProcessCacheLRU to MapCacheLRU
Change-Id: Iefe5c25e952079420b3241bc26efe1d2d086e6fb
Aaron Schulz [Wed, 11 Jul 2018 12:53:23 +0000 (13:53 +0100)]
filerepo: switch callers from ProcessCacheLRU to MapCacheLRU
Change-Id: I58706b5610e0113a0c8d86eed2662870198f9b46
David Causse [Tue, 10 Jul 2018 12:10:09 +0000 (14:10 +0200)]
Deprecate SearchEngine::replacePrefixes
This should be handled internally by SearchEngine implementations.
Bug: T198860
Change-Id: Ifbfd0fcb81fcacf5228bd2ffcac7b80fca872b2a
Depends-On: I7d4ff9498fa1f4ea66835c634b8931f4c29993fb
David Causse [Mon, 9 Jul 2018 16:55:54 +0000 (18:55 +0200)]
Unify SearchEngine normalizeNamespace and parseNamespacePrefixes
These methods are very similar there should be no need to have
two differents way to extract the namespace prefix.
Bug: T198860
Change-Id: I22802278452559d35a3d8f6068549c1fef1a5e86
David Causse [Mon, 25 Jun 2018 17:19:32 +0000 (19:19 +0200)]
Deprecate usage of SearchEngine:transformSearchTerm
This method was introduced in
4115586000a575eb814a80868c817d18ee169d3b
to support the prefix URI param introduced by the InputBox extension.
There are no reasons that this logic is exposed to SearchEngine users
and should be handled internally by SearchEngine implementations
that supports it.
Previously the search query was updated, now the prefix param will passed
along using SpecialSearch::$extraParams.
Bug: T198318
Change-Id: I33518d3f3ddee741ff4f3b47eb4928009bea66d1
Depends-On: I67c7f1886dd6a2d07c12015e2711c138e9f140e9
jenkins-bot [Tue, 17 Jul 2018 21:38:53 +0000 (21:38 +0000)]
Merge "Rephrase 'logeventslist-more-filters'"
jenkins-bot [Tue, 17 Jul 2018 20:40:03 +0000 (20:40 +0000)]
Merge "Introduce preference filters"
Bartosz Dziewoński [Tue, 17 Jul 2018 20:28:20 +0000 (22:28 +0200)]
Rephrase 'logeventslist-more-filters'
Bug: T117737
Change-Id: I6315ac76f8ddfeb024cb16331fc643ba726dfc34
Max Semenik [Fri, 6 Jul 2018 19:21:22 +0000 (12:21 -0700)]
Introduce preference filters
This normalizes handling of transformations on the boundaries between
preferences and generic form controls and removes the special case
where email-blacklist is passed around as an array internally, leaking
into the API.
As a result of this normalization, meta=userinfo no longer returns an
array of users, using the internal representation like action=options.
Bug: T198935
Change-Id: Iff63da0d215585cfcf083e7f7ec8ed45d5b77301
jenkins-bot [Tue, 17 Jul 2018 20:05:18 +0000 (20:05 +0000)]
Merge "LogEventsList: Remove unused messages"
Translation updater bot [Tue, 17 Jul 2018 19:54:08 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ia5e603f787ffeb5450d8695acee5f8dbde829ca8
jenkins-bot [Tue, 17 Jul 2018 18:52:18 +0000 (18:52 +0000)]
Merge "LogEventsListGetExtraInputs: Keep $input and add $formDescriptor"
Prateek Saxena [Fri, 13 Jul 2018 02:02:13 +0000 (07:32 +0530)]
LogEventsListGetExtraInputs: Keep $input and add $formDescriptor
Follows-up on Iba3c6aa5ac40dcdee0792c2d045b238b02d76521.
Bug: T117737
Bug: T199495
Change-Id: I697e158887fcca1da88763a4c929a981d9211490
jenkins-bot [Tue, 17 Jul 2018 07:15:45 +0000 (07:15 +0000)]
Merge "Revert "Convert Title::getTitleCache() to using MapCacheLRU""
Krinkle [Tue, 17 Jul 2018 07:01:17 +0000 (07:01 +0000)]
Revert "Convert Title::getTitleCache() to using MapCacheLRU"
This reverts commit
7a25cd388c8adcce60f4c055295baed71e730616.
Bug: T199763
Change-Id: I276b833d75e93328a188056bf1eb2491461d6d53
jenkins-bot [Tue, 17 Jul 2018 05:11:31 +0000 (05:11 +0000)]
Merge "Cached HTML/JS shouldn't show two toggle links"
jenkins-bot [Tue, 17 Jul 2018 05:05:44 +0000 (05:05 +0000)]
Merge "Clean up docs around $wgUseSharedUploads"
jenkins-bot [Tue, 17 Jul 2018 05:03:49 +0000 (05:03 +0000)]
Merge "WebRequest: Fix flaky testGetElapsedTime test case"
Fomafix [Wed, 11 Jul 2018 21:02:48 +0000 (14:02 -0700)]
Cached HTML/JS shouldn't show two toggle links
Per https://phabricator.wikimedia.org/T195053#
4417392
Bug: T195053
Change-Id: I43ff902055b338b434658e9bb1d6eacdc5684ba2
jenkins-bot [Tue, 17 Jul 2018 03:44:26 +0000 (03:44 +0000)]
Merge "filebackend: switch callers from ProcessCacheLRU to MapCacheLRU"
Timo Tijhof [Tue, 17 Jul 2018 03:23:30 +0000 (20:23 -0700)]
WebRequest: Fix flaky testGetElapsedTime test case
* Increase tolerance from 0.2s to 60s.
* Update mock to only set 'requestTime' when needed.
* Inject the mock timestamp.
* Increase test coverage by not just ensuring 0.0 is returned
when invoked right after (which would be satisfied if it
always returned 0.0), but use a timestamp that started
slightly in the past to confirm it does (likely) do
computation.
Bug: T199764
Change-Id: Iad9499391eecb4a9d1923d231a1a5f1afe173ecc
Brad Jorsch [Mon, 2 Jul 2018 15:17:06 +0000 (11:17 -0400)]
Parser: Remove style and script tags' content from TOC
We don't want to display the stylesheet as part of the TOC entry if
someone uses TemplateStyles in a heading.
Bug: T198618
Change-Id: I2f7316daaba0cce662b6a4702ab87322e6783655
jenkins-bot [Tue, 17 Jul 2018 02:49:58 +0000 (02:49 +0000)]
Merge "Sync up with Parsoid parserTests.txt"
jenkins-bot [Tue, 17 Jul 2018 01:09:25 +0000 (01:09 +0000)]
Merge "objectcache: make BagOStuff::mergeViaLock() timeout more sensible"
jenkins-bot [Tue, 17 Jul 2018 01:00:06 +0000 (01:00 +0000)]
Merge "objectcache: minor fix to MultiWriteBagOStuff::doWrite()"
Arlo Breault [Mon, 16 Jul 2018 22:56:16 +0000 (18:56 -0400)]
Sync up with Parsoid parserTests.txt
This now aligns with Parsoid commit
d473791ea982178af7a0fe15aff5cf8e21aaa5e8
Change-Id: Ide8a0d8df20242c9e60e40db653368ba3ef7a06c
Aaron Schulz [Wed, 11 Jul 2018 13:11:12 +0000 (14:11 +0100)]
Convert LinkCache to using MapCacheLRU
Clean up the variable names while at it.
Change-Id: I3b7860c0657111d73567e247bcc1ebcbaef53e22
jenkins-bot [Mon, 16 Jul 2018 21:14:53 +0000 (21:14 +0000)]
Merge "Convert ChangesList to using MapCacheLRU"
jenkins-bot [Mon, 16 Jul 2018 20:19:53 +0000 (20:19 +0000)]
Merge "New 'OutputPageAfterGetHeadLinksArray' hook, allowing extensions to modify the return value of OutputPage#getHeadLinksArray"
Translation updater bot [Mon, 16 Jul 2018 19:55:39 +0000 (21:55 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Id5530a817f15305e1befca60e09623b70b8652e8
Bartosz Dziewoński [Mon, 16 Jul 2018 16:30:55 +0000 (18:30 +0200)]
Set role=button on TOC show/hide checkbox
This should give more intuitive hints in assistive technology,
identical (or similar) to the hints for the JavaScript-generated
button we had before
68527cf47935a0350d3f0a153bd06cbb98062ec8.
See results of testing with Windows Narrator/VoiceOver: T195053#
4428563.
Bug: T195053
Change-Id: I9358b29f56ac1e43e9c5ed00d30ce6ffdf903299
jenkins-bot [Mon, 16 Jul 2018 15:44:52 +0000 (15:44 +0000)]
Merge "Convert Title::getTitleCache() to using MapCacheLRU"
jenkins-bot [Mon, 16 Jul 2018 15:19:42 +0000 (15:19 +0000)]
Merge "In PathRouterTest use @dataProvider where possible"
jenkins-bot [Mon, 16 Jul 2018 14:22:20 +0000 (14:22 +0000)]
Merge "mediawiki.page.gallery: Various clean up and minor optimisations"
jenkins-bot [Mon, 16 Jul 2018 09:23:55 +0000 (09:23 +0000)]
Merge "objectcache: avoid direct "bag" field references in CachedBagOStuff"
Tim Starling [Mon, 9 Jul 2018 04:56:21 +0000 (14:56 +1000)]
In PathRouterTest use @dataProvider where possible
"Where possible" turns out to be every test in this class.
I used named data sets (i.e. array keys in the provided array) for the
main set of tests, to improve the PHPUnit output.
Change-Id: Ic68edc01b3e0e174983471a36f3c5d52e28abfdd
Prateek Saxena [Mon, 16 Jul 2018 04:30:25 +0000 (10:00 +0530)]
LogEventsList: Remove unused messages
…and update documentation for $wgFilterLogTypes.
Follows-up on Iba3c6aa5ac40dcdee0792c2d045b238b02d76521.
Bug: T199657
Change-Id: I46c5836e4131423f930d59a1c5e7937339478c33
Translation updater bot [Sun, 15 Jul 2018 19:54:32 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I8fceb715311191c6ad73d5a0a5ec24e6009418f6
Daimona Eaytoy [Sun, 15 Jul 2018 13:35:11 +0000 (15:35 +0200)]
Temporarily skip broken Selenium test
This test was already flaky and was fixed in
I1fd0c49263e975c6b24e2e1f9a072486a6565dda. However, this caused failures
on several repos. Temporarily disable it until we'll get it to work
properly.
Bug: T199644
Change-Id: I88be83e01eb1789f28f09fc4a0be7ea17f402858
jenkins-bot [Sun, 15 Jul 2018 13:25:46 +0000 (13:25 +0000)]
Merge "Localize MW core namespaces to Santali"
Martin Urbanec [Sat, 14 Jul 2018 18:42:45 +0000 (20:42 +0200)]
Localize MW core namespaces to Santali
Bug: T198404
Change-Id: I4a68e55fc6771b9fc64ef823b399332d8eedfa38
jenkins-bot [Sat, 14 Jul 2018 23:39:43 +0000 (23:39 +0000)]
Merge "selenium: create edit for RecentChanges through GUI"
Jack Phoenix [Sat, 14 Jul 2018 22:54:40 +0000 (01:54 +0300)]
New 'OutputPageAfterGetHeadLinksArray' hook, allowing extensions to modify the return value of OutputPage#getHeadLinksArray
Code from wikiHow codebase, where this hook is used by the following extensions:
* AlternateDomain -- used to remove certain links altogether and change the contents of other elements (e.g. <meta description="..." />)
* hooks (PageHooks) -- used to hide certain links for anons on noindexed pages to avoid leaking article info to Googlebot
* QADomain -- used to remove certain elements and correct <meta keywords="..." /> tags not to mention "wikiHow" if that string is present
* search (LSearch) -- used to remove canonical URL on Special:LSearch for SEO
Change-Id: I4a9ceb343bb5c0b4eb79e4589d36c3790938f8a9
Jack Phoenix [Wed, 11 Jul 2018 08:06:10 +0000 (11:06 +0300)]
Pass $opts by reference to subscribers of 'SpecialSearchPowerBox' hook to allow them to modify it
wikiHow added a new hook called 'SpecialSearchPowerBoxOpts', which was passed only &$opts, so that the Finner extension can unset the $opts array. Enhancing the pre-existing hook is a better solution in this case.
Change-Id: I091cbdc78fc779144554d8420a95435b7048c407
jenkins-bot [Sat, 14 Jul 2018 22:33:29 +0000 (22:33 +0000)]
Merge "Add new 'ArticleShowPatrolFooter' hook to allow extensions to decide if the [mark as patrolled] link should not be shown"
jenkins-bot [Sat, 14 Jul 2018 22:31:22 +0000 (22:31 +0000)]
Merge "Don't throw E_NOTICEs about undefined properties"
Translation updater bot [Sat, 14 Jul 2018 20:00:57 +0000 (22:00 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I4fb9db02edc442a1b98b6e88d4715ba7f77dc402
Aaron Schulz [Wed, 11 Jul 2018 12:53:13 +0000 (13:53 +0100)]
filebackend: switch callers from ProcessCacheLRU to MapCacheLRU
Change-Id: I6efe7122ff30053a85461d31be7b5ddad0a5d2af
Aaron Schulz [Wed, 11 Jul 2018 13:04:36 +0000 (14:04 +0100)]
Convert ChangesList to using MapCacheLRU
Change-Id: I1cafb601dc644ca6d58ec0430e9608cfb497bcd8
Aaron Schulz [Wed, 11 Jul 2018 13:08:08 +0000 (14:08 +0100)]
Convert PasswordReset to using MapCacheLRU
Avoid NULL user name that caused test failures
Change-Id: Ifc3b19cc7e172300123e7d2c7153b4357917ca74
Timo Tijhof [Sat, 14 Jul 2018 01:22:44 +0000 (18:22 -0700)]
Clean up docs around $wgUseSharedUploads
* Remove references to these old configuration variables
from documentation. Rather than wgLocalFileRepo referring to
these for more information, move the docs there, and point
there from the old variables.
* Move all their declarations in DefaultSettings.php together,
and be in the same order as used in Setup.php.
* Add missing @var type and @since version docs.
Bug: T25122
Change-Id: I4eb9490ed4e978b2c3954de0593a9d0d3c5fe73c
jenkins-bot [Sat, 14 Jul 2018 00:40:15 +0000 (00:40 +0000)]
Merge "Mention MariaDB first, before MySQL in installer."
jenkins-bot [Sat, 14 Jul 2018 00:30:44 +0000 (00:30 +0000)]
Merge "Accept BCP 47 codes as aliases for nonstandard variants"
jenkins-bot [Sat, 14 Jul 2018 00:27:22 +0000 (00:27 +0000)]
Merge "tests: Add a doc test for release notes' existence and line length"
jenkins-bot [Sat, 14 Jul 2018 00:17:30 +0000 (00:17 +0000)]
Merge "Follow-up
267d99fa8: Fix RELEASE-NOTES-1.32 line length"
James D. Forrester [Tue, 3 Jul 2018 22:22:09 +0000 (15:22 -0700)]
tests: Add a doc test for release notes' existence and line length
Change-Id: I502bedc0221e52b78b15b1749918500842533e7c
C. Scott Ananian [Tue, 3 Jul 2018 20:12:38 +0000 (16:12 -0400)]
Accept BCP 47 codes as aliases for nonstandard variants
The browser Accept-Language header uses BCP 47 codes, which don't
precisely match our internal mediawiki variant names in a number of
places. Allow proper BCP 47 codes to alias our internal variants
for: Accept-Language parsing, URL parsing, user preferences, and
explicit enumeration of codes in LanguageConverter rules.
Change-Id: I8468a56d5b88f5786abd0a17b67bda2f1687fd0c
C. Scott Ananian [Fri, 13 Jul 2018 20:59:57 +0000 (16:59 -0400)]
Hard deprecate support for Parsoid v1 API
This was soft deprecated by
f5c874cbaf2c1408342305fbc87dc6db36728e07 in
May 2015, and support for the v1 API was removed from Parsoid in May 2016,
but the compatibility code has persisted zombie-like in core.
Hard deprecate this now, to warn anyone who might still be using ancient
copies of Visual Editor and Parsoid, and then we can slice the code out
in the next MW release.
Bug: T100681
Change-Id: I68e0ab5b38f31b7708ba6f075dcb3328dde118d1
jenkins-bot [Fri, 13 Jul 2018 20:45:38 +0000 (20:45 +0000)]
Merge "Revert "Pedantic strict equals.""
jenkins-bot [Fri, 13 Jul 2018 20:29:11 +0000 (20:29 +0000)]
Merge "Use func_num_args() in MapCacheLRU::clear() for sanity"
jenkins-bot [Fri, 13 Jul 2018 20:00:56 +0000 (20:00 +0000)]
Merge "Hard-deprecate ContentHandler::makeParserOptions()"
Translation updater bot [Fri, 13 Jul 2018 19:58:19 +0000 (21:58 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ibd2a95b4ebde7420a23dabbc3b8cdcfb12aa1452
jenkins-bot [Fri, 13 Jul 2018 19:28:25 +0000 (19:28 +0000)]
Merge "Ensure LanguageCode::bcp47() returns a valid BCP 47 language code"
Daniel Kinzler [Fri, 13 Jul 2018 19:27:02 +0000 (19:27 +0000)]
Revert "Pedantic strict equals."
This reverts commit
b24fafd6066f8bffeb2b4c0b9e8e22d1b2f07cf2.
Reason for revert: T199504
The strict comparisons changes semantics when parameters are not set and thus null.
This could be fixed by setting the right defaults when getting parameter values, but needs a closer look.
Bug: T199504
Change-Id: I7b3e5d4f4d50af6603b3414be099d5bda6571387
jenkins-bot [Fri, 13 Jul 2018 19:01:20 +0000 (19:01 +0000)]
Merge "rcfilters: Fix filter menu checkbox alignment after OOUI v0.27.5 release"
C. Scott Ananian [Tue, 26 Jun 2018 20:39:57 +0000 (16:39 -0400)]
Ensure LanguageCode::bcp47() returns a valid BCP 47 language code
MediaWiki uses a number of nonstandard codes which do not validate
according to the IANA language subtag registry. Some of them have
the wrong semantics entirely: MediaWiki's `sr-ec` variant maps to
BCP 47 `sr-EC` which is "Serbian as used in Ethiopia" (!).
Extend LanguageCode::bcp47() to map our nonstandard codes to valid
BCP 47 language codes. Export the mapping so that it can be used
in JavaScript's corresponding mw.language.bcp47() implementation
as well.
Thanks to TheDJ (I10b4473c7e53f027812bbccf26bb47aec15fddfd) and
Fomafix (I93efc190714ba76247d30ba49fc21ae872fc3555) for previous
attempts at this!
Also removed a fixme for the name of 'Twi', dating back to 2004
(
f59c3be23b209e178a917cb14ebedcc243c847b6) -- checking
tw.wikipedia.org it certainly appears that the autonym of 'Twi'
is correctly 'Twi'.
Tracking bugs for invalid language codes are T125073 and T145535.
Discussion of zh-XX => zh-HanX-XX mapping is at T198419.
Bug: T34483
Bug: T106367
Bug: T120847
Change-Id: I807dd55d49e9bd19443329231326a5b0d3e6c453
Brad Jorsch [Wed, 11 Jul 2018 16:14:53 +0000 (12:14 -0400)]
Hard-deprecate ContentHandler::makeParserOptions()
Followup to I01373b29.
Bug: T194263
Change-Id: I8c5a2a1485d515373d1a0005ee0f5ee782690a2c
Depends-On: I2260fe7322cace9003c3c17be95cfba8df4bdbbe
Depends-On: I7e6a17466ba17f85b4f247b329a0d248855abdd1
Depends-On: I254a583b7f7ddd1797aa40f0ddfb973161185a49
Depends-On: Ib8ed827012c7bd73fcdaa6c0c6edd44869c79f14
Depends-On: Ia95f3e2c1ea944366ff9a478c3c86f8565023394
Depends-On: I4b591969166acdd73ed70b117a7a135d993fa42a
Brad Jorsch [Wed, 11 Jul 2018 16:13:18 +0000 (12:13 -0400)]
Deprecate ContentHandler::makeParserOptions()
Having a different ParserOptions for each content model isn't feasible
in an MCR world. And the only thing using this was Wikibase, which has
been fixed to do what it needs in a different way.
Bug: T194263
Change-Id: I01373b29ee25fa9346c6b0317155be4ccdc8c515
jenkins-bot [Fri, 13 Jul 2018 17:58:03 +0000 (17:58 +0000)]
Merge "Hard deprecate Language::truncate()"
James D. Forrester [Fri, 13 Jul 2018 17:33:24 +0000 (10:33 -0700)]
rcfilters: Fix filter menu checkbox alignment after OOUI v0.27.5 release
Bug: T199466
Change-Id: I3ab314d76f9f14aa8bac3d8a840c55e7e00e29e3
jenkins-bot [Fri, 13 Jul 2018 17:22:34 +0000 (17:22 +0000)]
Merge "Don't armor french spaces before punctuation followed by word characters"
jenkins-bot [Fri, 13 Jul 2018 17:19:45 +0000 (17:19 +0000)]
Merge "Add test for PageArchive::getPreviousRevision"
jenkins-bot [Fri, 13 Jul 2018 16:57:36 +0000 (16:57 +0000)]
Merge "Put <dt>/<dd>/<li> in the always-suppressing category of doBlockLevels"
jenkins-bot [Fri, 13 Jul 2018 16:44:45 +0000 (16:44 +0000)]
Merge "Use a closure instead of PathRouterPatternReplacer"
Arlo Breault [Thu, 12 Jul 2018 18:41:20 +0000 (14:41 -0400)]
Put <dt>/<dd>/<li> in the always-suppressing category of doBlockLevels
This is a clarification of what already happens in practice for lists
generated from wikitext syntax, since that parsing happens
simultaneously.
Parsoid, for its part, does list handling prior to paragraph wrapping,
so must make use of these definitions.
Further, this helps reduce paragraph wrapping in interstitial spacing of
lists from HTML syntax, as spec'd in the tests, though the possibility
isn't eliminated entirely.
The TOC generation code is altered to reduce the number of newlines
emitted in between list items, since those are now left intact.
Change-Id: I6888b6e8e6768b0737565b87924fefa5a06ebd18
jenkins-bot [Fri, 13 Jul 2018 16:22:46 +0000 (16:22 +0000)]
Merge "<ins>/<del> elements can be phrasing or flow"
Arlo Breault [Thu, 12 Jul 2018 18:31:04 +0000 (14:31 -0400)]
<ins>/<del> elements can be phrasing or flow
The changes to the parserTests.txt highlight the differing opinions that
doBlockLevels and Remex had on whether these should be paragraph wrapped.
Since the only time they wouldn't have been was when found on a line
with other flow tags, this likely isn't a behaviour that was depended on
in practice. And, indeed, the task describes this as a bug.
A sampling of pages from an insource:/\<(ins|del)\>/ search on wiki bears
this out.
Bug: T17491
Change-Id: I311da777a63aa3c45013f2cfc090be35a022497e
Pablo Grass [Fri, 13 Jul 2018 15:18:20 +0000 (17:18 +0200)]
selenium: create edit for RecentChanges through GUI
Use page object to create the page we will be asserting on
Special:RecentChanges. Apparently (post send) jobs are not executed on
API calls (that were formerly used for test setup) and consequently
presence of the edit on Special:RecentChanges could not be guaranteed.
Bug: T199446
Change-Id: I1fd0c49263e975c6b24e2e1f9a072486a6565dda
Aaron Schulz [Fri, 13 Jul 2018 14:15:52 +0000 (15:15 +0100)]
Use func_num_args() in MapCacheLRU::clear() for sanity
Change-Id: Ie11e18a342db0176271e4d08f56a99b0e3caacbe
daniel [Fri, 13 Jul 2018 10:16:36 +0000 (12:16 +0200)]
Add test for PageArchive::getPreviousRevision
Regression test for I4e2031f9625744
Change-Id: Id22984bf7d1c3d6f57e827e9f1283231918b59b1
David Causse [Fri, 13 Jul 2018 09:25:10 +0000 (11:25 +0200)]
[PageArchive] Fetch ar_rev_id instead of ar_id
Introduced in I92afda8, the query fetches ar_id but the code expects
ar_rev_id.
Change-Id: I4e2031f96257449a264142a6d697aca802e897df
Timo Tijhof [Fri, 13 Jul 2018 05:22:31 +0000 (22:22 -0700)]
mediawiki.page.gallery: Various clean up and minor optimisations
* Moved some variables to a lower scope more appropiate,
to make it easier to understand what they are used for,
and to reduce chances of mistakes in the future.
* Use push() instead of .length assignment.
* Use the same property for checks as for access ([0] vs length),
also potentially faster, but nothing worth mentioning.
* Avoid duplicate $this.outerWidth(), expensive computation.
Bug: T88654
Change-Id: Ib03d05a5c6422afdec11c56360bd568bdb2633fb
Timo Tijhof [Fri, 13 Jul 2018 04:15:39 +0000 (21:15 -0700)]
installer: Add missing new-line after "comment fields are up to date"
Before:
> ...comment fields are up to date...hitcounter doesn't exist.
> ...site_stats table does not contain ss_total_views field.
After:
> ...comment fields are up to date.
> ...hitcounter doesn't exist.
> ...site_stats table does not contain ss_total_views field.
Change-Id: Ia99758f9af379a84c20d99e05838802965def3b6
Jack Phoenix [Fri, 13 Jul 2018 03:33:10 +0000 (06:33 +0300)]
Don't throw E_NOTICEs about undefined properties
Bug: T199494
Change-Id: Id24b9ece76ca0bedcaac29f1a6f5567af78658c1
jenkins-bot [Fri, 13 Jul 2018 02:08:00 +0000 (02:08 +0000)]
Merge "Let 'shows page creation' test be skipped"
Stephane Bisson [Thu, 12 Jul 2018 12:34:56 +0000 (08:34 -0400)]
Let 'shows page creation' test be skipped
Troubleshooting can happen in parallel without blocking
unrelated work from being merged.
Bug: T198137
Change-Id: Ie84a868a580968ff99ff6879050080c6495fa72a
jenkins-bot [Thu, 12 Jul 2018 23:39:05 +0000 (23:39 +0000)]
Merge "Replace use of deprecated Language::truncate()"
James D. Forrester [Thu, 12 Jul 2018 21:30:41 +0000 (14:30 -0700)]
Follow-up
267d99fa8: Fix RELEASE-NOTES-1.32 line length
Change-Id: Ib239734a5e0c7d4a6915e6712e6d4767e839f6d9
Translation updater bot [Thu, 12 Jul 2018 20:16:15 +0000 (22:16 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Iae46fa70b5925ec04bf8d2fda05695e2e7af64d0
Adam Wight [Thu, 5 Jul 2018 12:33:24 +0000 (14:33 +0200)]
Pedantic strict equals.
Change-Id: I53b046def3ce44b218490ee2a1f0a77dc27825d7
jenkins-bot [Thu, 12 Jul 2018 18:56:07 +0000 (18:56 +0000)]
Merge "WebReponse: Use values altered in 'WebResponseSetCookie' hook"
jenkins-bot [Thu, 12 Jul 2018 18:34:46 +0000 (18:34 +0000)]
Merge "Fix populateContentTables.php with no rows"
Brad Jorsch [Wed, 11 Jul 2018 19:00:41 +0000 (15:00 -0400)]
Fix populateContentTables.php with no rows
MIN() and MAX() return null if there are no rows. Fill in a dummy row in
that case.
Change-Id: I7caba98a5ec30e15e19d49effa22a70c78a71c28
Kevin Israel [Tue, 10 Jul 2018 15:14:29 +0000 (11:14 -0400)]
StringUtils: Deprecate Replacer classes
The Replacer classes were added in 1.9, when MediaWiki supported PHP 5.0
and 5.1. They were designed to be used with preg_replace_callback() and
StringUtils::delimiterReplaceCallback(). Now that Closures exist in PHP
5.3 and newer, there is no need to define a class for this purpose.
All existing Replacer subclasses are simple enough that their few uses
can easily be replaced with Closures, without making the code harder to
understand. In fact, the code probably becomes easier to understand, as
what each match is replaced with becomes more obvious -- no need to
refer to a separate class.
MediaWiki code search finds no uses in extensions. Thus, these classes
are hard deprecated immediately.
Change-Id: I441c21689909fb06a1ea07a305259eeb82cb2345
jenkins-bot [Thu, 12 Jul 2018 17:23:49 +0000 (17:23 +0000)]
Merge "Deprecate specialized file errors in OutputPage and fix escaping"
jenkins-bot [Thu, 12 Jul 2018 17:22:14 +0000 (17:22 +0000)]
Merge "Start working on phan-taint-check warnings. Fix minor escaping issues."